Actually share reference to text in CommonToken.fromToken #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 75.51% 75.51%
=======================================
Files 159 159
Lines 10503 10503
Branches 1612 1612
=======================================
Hits 7931 7931
Misses 2008 2008
Partials 564 564 |
sharwell
approved these changes
Apr 23, 2019
BurtHarris
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a java conversion error.
The doc comment above (and java version) attempt to share the string/reference if the fromToken is a CommonToken.
However, the field got underscored'd in the conversion to typescript, and it looks like only the LHS got updated.
The upshot is that the without this change, if oldToken is a CommonToken, it will retrieve and copy the text from the oldToken, not share it.
With this change, it will share the reference if possible.