Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appearance listener for newer RN versions #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vforvasile
Copy link

Hey!

In 0.70+ the current Appearance event listener syntax is not allowed anymore. I made a quick fix

⚠️ I'm not entirely sure, but this might break older versions of RN (lower than 0.66)

We could try to make it backwards compatible with older versions.

@pederjohnsen
Copy link
Member

@vforvasile thanks for this ❤️

I really need to set aside some time to put some more love into this project, just been extremely busy with a ton of other stuff 🥲

I'll try make some time to look over this and test over the weekend 👍🏻

@pederjohnsen pederjohnsen self-requested a review July 28, 2023 11:22
@pederjohnsen pederjohnsen self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants