Migrate to Vue3 #59
Merged
Migrate to Vue3 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
force-pushed
the
vue3
branch
5 times, most recently
from
bb11724 to
12beaa9
Compare
|
Half way there. Unit tests passing, just setting up Cypress again, then will have to fix the e2e test, and finally make the tabs custom name work (or remove that feature… 🤔 😓 ) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
===========================================
+ Coverage 47.05% 97.82% +50.76%
===========================================
Files 2 6 +4
Lines 51 92 +41
Branches 1 8 +7
===========================================
+ Hits 24 90 +66
+ Misses 27 0 -27
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kinow
commented
Jan 14, 2024
| @@ -78,7 +78,7 @@ describe('Lumino component', () => { | |||
| .should('be.visible') | |||
| // SVG element is used only in the ColoredCircle component | |||
| cy.get('svg') | |||
| .should('not.be.visible') | |||
| .should('not.exist') | |||
There was a problem hiding this comment.
kinow
force-pushed
the
vue3
branch
2 times, most recently
from
69c1e7e to
f790512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51
Cannot resolve the issue #53 as we have a slot with one or multiple elements, and we have no easy way to retrieve each element and “teleport” it to its right destination.