Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid module imports don't work as expected #20

Closed
turbobabr opened this issue Oct 21, 2014 · 4 comments
Closed

Invalid module imports don't work as expected #20

turbobabr opened this issue Oct 21, 2014 · 4 comments
Milestone

Comments

@turbobabr
Copy link
Owner

It seems that MSPlugin.scriptWithExpandedImports:path: method resolves paths differently than my implementation. Here is the result I get when running an old plugin that actually works in sketch:
bitmap

Should turn off the whole imports checking module and revisit it later.

@getflourish
Copy link

Not sure if it’s is related to this topic, but plugins that have imports don’t work anymore as soon as the console did open. Dev Tools Console says the Script executed but nothing really happens. Log from OS X console:

24/10/14 20:56:09,223 Sketch[4733]: -[TDToken quotedString]: unrecognized selector sent to instance 0x60000185b300

24/10/14 20:56:09,223 Color Inventory (Sketch Plugin)[4733]: Caught script exception: -[TDToken quotedString]: unrecognized selector sent to instance 0x60000185b300

@turbobabr
Copy link
Owner Author

Holy crap! Thank you for reporting this. Will try to fix it ASAP!

@turbobabr turbobabr added this to the 0.2.0 milestone Oct 28, 2014
@turbobabr
Copy link
Owner Author

Florian,

I've found a problem, and now it works like a charm! :)
Here is the proof:
bitmap

The fix isn't published yet, because I have to ask a few questions to Sam about file paths resolving mechanism. I think that fix will be available tomorrow.

@getflourish
Copy link

Great! Thanks buddy :)

On Tue, Oct 28, 2014 at 8:40 AM, Andrey Shakhmin notifications@github.com
wrote:

Florian,
I've found a problem, and now it works as a charm! :)
Here is the proof:
bitmap

The fix isn't published yet, because I have to ask a few questions to Sam about file paths resolving mechanism. I think that fix will be available tomorrow.

Reply to this email directly or view it on GitHub:
#20 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants