Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC balance method #236

Merged
merged 1 commit into from
Oct 20, 2023
Merged

gRPC balance method #236

merged 1 commit into from
Oct 20, 2023

Conversation

keppel
Copy link
Contributor

@keppel keppel commented Oct 20, 2023

This PR adds an implementation of balance() to the gRPC bank service to prevent a warning message in hermes.

@keppel keppel enabled auto-merge October 20, 2023 17:36
@keppel keppel added this pull request to the merge queue Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (93e95ea) 58.49% compared to head (d383a68) 58.47%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
- Coverage    58.49%   58.47%   -0.02%     
===========================================
  Files           84       84              
  Lines        15662    15667       +5     
===========================================
  Hits          9161     9161              
- Misses        6501     6506       +5     
Files Coverage Δ
src/ibc/service.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into develop with commit 71a792a Oct 20, 2023
@keppel keppel deleted the grpc-balance branch October 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant