Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC revision number parsing #240

Merged
merged 2 commits into from
Oct 20, 2023
Merged

gRPC revision number parsing #240

merged 2 commits into from
Oct 20, 2023

Conversation

keppel
Copy link
Contributor

@keppel keppel commented Oct 20, 2023

This PR updates the IBC gRPC channel service to parse the revision number from the chain ID more liberally.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (4f6d410) 59.07% compared to head (0007b6f) 59.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #240      +/-   ##
===========================================
- Coverage    59.07%   59.05%   -0.02%     
===========================================
  Files           84       84              
  Lines        15701    15706       +5     
===========================================
  Hits          9275     9275              
- Misses        6426     6431       +5     
Files Coverage Δ
src/ibc/service.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keppel keppel enabled auto-merge October 20, 2023 23:28
@keppel keppel added this pull request to the merge queue Oct 20, 2023
Merged via the queue into develop with commit cf117f1 Oct 20, 2023
5 of 7 checks passed
@keppel keppel deleted the grpc-rev-num branch October 20, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant