Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LengthString deserialize fix #274

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

mappum
Copy link
Contributor

@mappum mappum commented Nov 15, 2024

This PR fixes LengthString always setting a length of 0 when deserializing.

@mappum mappum force-pushed the lengthstring-deserialize-fix branch from 6a9d720 to 296a691 Compare November 15, 2024 00:11
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.93%. Comparing base (ff7eab1) to head (296a691).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
src/encoding.rs 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    56.97%   56.93%   -0.04%     
===========================================
  Files           82       82              
  Lines        15851    15861      +10     
===========================================
  Hits          9031     9031              
- Misses        6820     6830      +10     
Files with missing lines Coverage Δ
src/encoding.rs 61.97% <0.00%> (-2.27%) ⬇️

Impacted file tree graph

@keppel keppel added this pull request to the merge queue Nov 15, 2024
Merged via the queue into develop with commit 89e919b Nov 15, 2024
7 checks passed
@keppel keppel deleted the lengthstring-deserialize-fix branch November 15, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants