Flowpipe pipeline param default value compatibility test with the dec…

…lared type may fail for complex types. Fixes #441.

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 Shared Pipes Component
 
+## v1.5.2 [2024-08-14]
+
+* Flowpipe pipeline param default value compatibility test with the declared type may fail for complex types. ([#441](https://github.com/turbot/pipe-fittings/issues/441)) 
+
 ## v1.5.1 [2024-08-13]
 
 _Bug fixes_

hclhelpers/compatible.go

@@ -9,21 +9,36 @@ func IsValueCompatibleWithType(ctyType cty.Type, value cty.Value) bool {
 
 	valueType := value.Type()
 
-	if ctyType.IsMapType() {
+	if ctyType.IsMapType() || ctyType.IsObjectType() {
 		if valueType.IsMapType() || valueType.IsObjectType() {
-			mapElementType := ctyType.ElementType()
+			if ctyType.IsCollectionType() {
+				mapElementType := ctyType.ElementType()
 
-			// Ensure the value is known before iterating over it to avoid panic
-			if value.IsKnown() {
-				for it := value.ElementIterator(); it.Next(); {
-					_, mapValue := it.Element()
-					if !IsValueCompatibleWithType(mapElementType, mapValue) {
+				// Ensure the value is known before iterating over it to avoid panic
+				if value.IsKnown() {
+					for it := value.ElementIterator(); it.Next(); {
+						_, mapValue := it.Element()
+						if !IsValueCompatibleWithType(mapElementType, mapValue) {
+							return false
+						}
+					}
+					return true
+				} else {
+					return false
+				}
+			} else if ctyType.IsObjectType() {
+				typeMapTypes := ctyType.AttributeTypes()
+				for name, typeValue := range typeMapTypes {
+					if valueType.HasAttribute(name) {
+						innerValue := value.GetAttr(name)
+						if !IsValueCompatibleWithType(typeValue, innerValue) {
+							return false
+						}
+					} else {
 						return false
 					}
 				}
 				return true
-			} else {
-				return false
 			}
 		}
 	}

hclhelpers/compatible_test.go

@@ -224,6 +224,16 @@ var compatibleTests = map[string]compatibleTest{
 		value:    cty.ListVal([]cty.Value{cty.ListVal([]cty.Value{cty.ListVal([]cty.Value{cty.ListVal([]cty.Value{cty.NumberIntVal(23), cty.NumberIntVal(42)})})})}),
 		expected: false,
 	},
+	"map of an object": {
+		ctyType:  cty.Map(cty.Object(map[string]cty.Type{"foo": cty.String, "bar": cty.String})),
+		value:    cty.MapVal(map[string]cty.Value{"foo": cty.ObjectVal(map[string]cty.Value{"foo": cty.StringVal("foo"), "bar": cty.StringVal("bar")})}),
+		expected: true,
+	},
+	"map of an object 2": {
+		ctyType:  cty.Map(cty.Object(map[string]cty.Type{"foo": cty.String, "bar": cty.Number})),
+		value:    cty.ObjectVal(map[string]cty.Value{"foo": cty.ObjectVal(map[string]cty.Value{"foo": cty.StringVal("foo"), "bar": cty.NumberIntVal(42)})}),
+		expected: true,
+	},
 }
 
 func TestCompatible(t *testing.T) {