Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _ctx column to all tables #246

Closed
kaidaguerre opened this issue Jan 25, 2022 · 5 comments
Closed

Add _ctx column to all tables #246

kaidaguerre opened this issue Jan 25, 2022 · 5 comments
Assignees

Comments

@kaidaguerre
Copy link
Contributor

No description provided.

@e-gineer
Copy link
Contributor

What's the name of this column going to be?

steampipe_connection
sp_connection
_connection
other?

@kaidaguerre
Copy link
Contributor Author

kaidaguerre commented Jan 26, 2022

good question @e-gineer - whatever we choose will be a reserved name

I'm going with steampipe_connection for now but easy to change

maybe _steampipe_connection ?

@e-gineer
Copy link
Contributor

@johnsmyth what do you think?

i think steampipe_connection is long, but probably best.

@johnsmyth
Copy link
Contributor

its long, but its unambiguous. I think steampipe_connection is fine. @e-gineer at one point we talked about putting the connection name in a json steampipe_context field so that there would be a single column for steampipe-related info that we could extend later if needed - do you think we should consider that instead?

@johnsmyth
Copy link
Contributor

Proposed:

  • column name: _ctx
  • format: jsonb
{ 
  "connection_name":  "my_connection"
}

This will allow us to add other fields when requirements dictate, but still makes getting the connection name simple: select _ctx ->> 'connection_name' from ...

@kaidaguerre kaidaguerre changed the title Add steampipe_connection column to all tables Add _ctx column to all tables Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants