-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for key columns which require exact matching to be considered a cache hit #298
Comments
@kaidaguerre is the below case also because of the above-mentioned issue?
|
@LalitTurbot is |
Yes |
kaidaguerre
added a commit
that referenced
this issue
Mar 24, 2022
…olumns which require exact matching to be considered a cache hit. Closes #298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, in the turbot plugin,
turbot_resource
table, thefilter
column represents a filter string which is executed to retrieve the data. The filter column value is provided by the query qual, for exampleif no filter is provided in the qual, the filter column will not have any data
When checking for a cache hit, normally accept data which has fewer quals. For example, if the cached data has the qual
we would expect this data to be a superset of the data returned from
However in the case of filter columns this will NOT be the case, as the data returned by
will have null values for the filter column whereas
will not.
So we need to introduce a flag which ensures that when checking if existing cached data contains all the data required for a given query, specific quals have exact matches.
So in this case, we need the cached data to have the qual value
In the case where the cached data has the qual value
this will no longer be considered a super set of
so will NOT be a cache hit.
The text was updated successfully, but these errors were encountered: