Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error for missing required quals. Closes #40 #42

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Fix error for missing required quals. Closes #40 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugin/table_fetch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (t *Table) fetchItems(ctx context.Context, queryData *QueryData) error {
func (t *Table) executeGetCall(ctx context.Context, queryData *QueryData) (err error) {
logger := t.Plugin.Logger
// verify we have the necessary quals
if queryData.KeyColumnQuals == nil {
if len(queryData.KeyColumnQuals) == 0 {
return status.Error(codes.Internal, fmt.Sprintf("'Get' call requires an '=' qual for %s", t.Get.KeyColumns.ToString()))
}

Expand Down Expand Up @@ -240,7 +240,7 @@ func (t *Table) executeListCall(ctx context.Context, queryData *QueryData) {
}()

// verify we have the necessary quals
if t.List.KeyColumns != nil && queryData.KeyColumnQuals == nil {
if t.List.KeyColumns != nil && len(queryData.KeyColumnQuals) == 0 {
queryData.streamError(status.Error(codes.Internal, fmt.Sprintf("'List' call requires an '=' qual for %s", t.List.KeyColumns.ToString())))
}

Expand Down