Skip to content

Commit

Permalink
Remove NOTICE level elog statements (#470)
Browse files Browse the repository at this point in the history
  • Loading branch information
pskrbasu authored May 17, 2024
1 parent 5d4d3f9 commit fd32299
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
9 changes: 0 additions & 9 deletions fdw/fdw.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,11 +186,6 @@ static int deparseLimit(PlannerInfo *root)
bms_num_members(root->all_baserels) != 1)
return -1;

if (root->parse->sortClause != NULL) {
elog(NOTICE, "deparseLimit - there are sortClause");
}


/* only push down constant LIMITs that are not NULL */
if (root->parse->limitCount != NULL && IsA(root->parse->limitCount, Const))
{
Expand Down Expand Up @@ -247,16 +242,13 @@ static void fdwGetForeignPaths(PlannerInfo *root, RelOptInfo *baserel, Oid forei
{
List *deparsed;

elog(NOTICE, "fdwGetForeignPaths - there are query_pathkeys");
deparsed = deparse_sortgroup(root, foreigntableid, baserel);
if (deparsed)
{
/* Update the sort_*_pathkeys lists if needed */
fdw_private->canPushdownAllSortFields = computeDeparsedSortGroup(deparsed, planstate, &apply_pathkeys, &fdw_private->deparsed_pathkeys);
elog(NOTICE, "computeDeparsedSortGroup returned canPushdownAllSortFields: %d", fdw_private->canPushdownAllSortFields);
} else {
/* deparse_sortgroup failed returns empty list if no pathkeys for the PlannerInfo */
elog(NOTICE, "fdwGetForeignPaths - deparse_sortgroup returned nothing - no sort groupos to pushdown - mark canPushdownAllSortFields as true");
fdw_private->canPushdownAllSortFields = true;
}
}
Expand Down Expand Up @@ -325,7 +317,6 @@ static ForeignScan *fdwGetForeignPlan(
planstate->pathkeys = pathdata->deparsed_pathkeys;
}
else {
elog(NOTICE, "fdwGetForeignPlan - best_path->fdw_private is NULL. Defaulting to setting canPushdownAllSortFields to true");
planstate->canPushdownAllSortFields = true;
planstate->pathkeys = NULL;
}
Expand Down
2 changes: 0 additions & 2 deletions fdw/query.c
Original file line number Diff line number Diff line change
Expand Up @@ -418,8 +418,6 @@ bool computeDeparsedSortGroup(List *deparsed, FdwPlanState *planstate,
int numSortableFields = list_length(deparsed);
bool canPushdownAllSortFields = numSortFields == numSortableFields;

elog(NOTICE, "computeDeparsedSortGroup: numSortFields %d, numSortableFields %d, canPushdownAllSortFields %d", numSortFields, numSortableFields, canPushdownAllSortFields);

/* Don't go further if FDW can't enforce any sort */
if (sortable_fields == NIL)
return false;
Expand Down

0 comments on commit fd32299

Please sign in to comment.