Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Docker credStore breaks plugin installations with private registries #4330

Closed
graza-io opened this issue Jul 12, 2024 · 0 comments · Fixed by #4329
Closed

Removing Docker credStore breaks plugin installations with private registries #4330

graza-io opened this issue Jul 12, 2024 · 0 comments · Fixed by #4329
Assignees
@graza-io
Labels
bug Something isn't working

Comments

@graza-io
Copy link
Contributor

@pdecat reported that our not yet released change to remove the Docker credStore was breaking installation from his private GitLab OCI registry:

# steampipe plugin install registry.myhost/myproject/steampipe-plugin-myplugin


registry.myhost/myproject… [====================================================================] Done

Skipped the following plugin:

Plugin:   steampipe-plugin-myplugin@latest
Reason:   failed to resolve latest: GET "https://registry.myhost/myproject/steampipe-plugin-myplugin/manifests/latest": GET "https://git.fr.clara.net/jwt/auth?scope=repository%3Amyproject%2Fsteampipe-plugin-myplugin%3Apull&service=container_registry": response status code 403: denied: access forbidden

Solution is to support this as default unless using our specific GHCR registry, in which case we'll skip Docker credStore and use the ORAS default approach.
@graza-io graza-io added the bug Something isn't working label Jul 12, 2024
@graza-io graza-io self-assigned this Jul 12, 2024
@graza-io graza-io linked a pull request Jul 12, 2024 that will close this issue
fix: fixed credStore to use Docker when not Turbot GHCR #4329
Merged
pskrbasu pushed a commit that referenced this issue Jul 17, 2024
@graza-io @pskrbasu
fix: fixed credStore to use Docker when not Turbot GHCR. Closes #4330
02b18b1
kaidaguerre added a commit that referenced this issue Jul 18, 2024
@pskrbasu @graza-io @kaidaguerre
Release steampipe v0.23.3.
e808eb7 
* fix: skips docker config for credential store, allows GHCR to work if docker-credential-desktop not on PATH. Closes #4323

* v0.23.3. Closes #4328

* Update CHANGELOG for v0.23.3

* Update goreleaser args

* Use goreleaser v1

* fix: fixed credStore to use Docker when not Turbot GHCR. Closes #4330

* Update CHANGELOG

* Update FDW to v1.11.4 (#4334)

---------

Co-authored-by: Graza <code@graza.io>
Co-authored-by: kai <kai@turbot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graza-io graza-io

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed credStore to use Docker when not Turbot GHCR turbot/steampipe
1 participant
@graza-io