Kon Ham #428
Open
Kon Ham #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap2322
reviewed
Jan 18, 2021
| frogs -= 1 | ||
| puts "then there were #{frogs} speckled frogs." | ||
| end | ||
| if frogs === 1 |
There was a problem hiding this comment.
Question for you to research: What's the difference in Ruby between =, ==, and ===?
Comment on lines
+15
to
+20
| if high % 15 === 0 | ||
| print "FizzBuzz" | ||
| elsif high % 5 === 0 | ||
| print "Buzz" | ||
| elsif high % 3 === 0 | ||
| print "Fizz" |
There was a problem hiding this comment.
Seems like these lines are repeated from inside your while loop. This is a good candidate to refactor so you don't have repeating conditionals with the same output.
Comment on lines
+9
to
+11
| Let's make a function that will take two parameters: the string that the user wants to encrypt, and the number of degrees we will shift our alphabet to the left. | ||
|
|
||
| `def caesar_cipher(string, degrees)` |
There was a problem hiding this comment.
Nice work making a clear step-by-step document with some code snippets to illustrate the explanation of how you'll go about making a caesar cipher.
Comment on lines
+17
to
+27
| def add_topping(topping) | ||
| toppings.push(topping) | ||
| end | ||
|
|
||
| def remove_topping(topping) | ||
| toppings.delete(topping) | ||
| end | ||
|
|
||
| def change_protein(protein) | ||
| self.protein = protein | ||
| end |
There was a problem hiding this comment.
Another way of updating the attributes directly is to use the instance variable @protein (or @toppings).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my prework!