-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leigh Cepriano Pulzone #441
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leigh, Great work on this! I've left some high level comments below. Keep up the great work!
while y > 1 | ||
puts "#{y} speckled frogs sat on a log" | ||
puts "eating some most delicious bugs." | ||
puts "One jumped in the pool where its nice and cool," | ||
puts "then there were #{y - 1} speckled frogs." | ||
y -= 1 | ||
end | ||
puts "#{y} speckled frogs sat on a log" | ||
puts "eating some most delicious bugs." | ||
puts "One jumped in the pool where its nice and cool," | ||
puts "then there were no more speckled frog!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, nice use of iteration. Refactor opportunity to remove repeating lines. Nice job working through an extension.
# https://medium.com/@alexander.virga/ruby-simple-string-encryption-shift-caesar-cipher-encoder-rot-9dedf06374d1 | ||
# I did not create this, I copied it from the website listed above so that I could understand what each line does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this kind of documentation as you work through problems!
### My thoughts on the one of the oldest methods of data encryption | ||
A Caesar Cipher is going to take our input and create a coded message. In order to do this I looked up a few different methods. Below is a method I found from this website. `https://medium.com/@alexander.virga/ruby-simple-string-encryption-shift-caesar-cipher-encoder-rot-9dedf06374d1` I have a fairly basic understanding of this so I thought I would copy the method I copied from the website and explain what each line is doing. What I have found is that being able to type out the code and explain it that way. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, great job being transparent about working through a found solution.
This exercise is to get you to think about algorithmic thinking - like writing down a recipe - writing each step you need to accomplish to make the cipher. You should then be able to take your steps (written in plain language), and write code for each step.
Good work writing what each piece of code does along with example outputs. A challenge would be to write the "what each step does" part first, and then come up with the code.
def add_topping(extra) | ||
@toppings.push(extra) | ||
puts "I'll add #{extra}, please." | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work updating the class attributes directly.
Here is my prework! I learned SO much and made lasting friendships with my peers in order to comprehend the material. What a wild ride, can't wait for it to actually begin! 🦖😁