Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes issue with docker compose yml (closes #62) #63

Merged
merged 3 commits into from
Sep 23, 2020
Merged

fixes issue with docker compose yml (closes #62) #63

merged 3 commits into from
Sep 23, 2020

Conversation

jritsema
Copy link

@jritsema jritsema commented Sep 22, 2020 •
edited
Loading

@jritsema
improves compose parsing error handling
462c2d8
@jritsema
fixes issue with docker compose yml (closes #62)
fdd5679 
The latest version of docker-compose has a breaking change in the yaml
schema of the config command.
@jritsema
removes code
b1ce6f6
@jritsema jritsema requested review from ajliv and awlawl September 22, 2020 16:25
@jritsema jritsema self-assigned this Sep 22, 2020
@jritsema jritsema requested a review from mjreed-wbd September 22, 2020 16:26
@jritsema jritsema linked an issue Sep 22, 2020 that may be closed by this pull request
error when deploying a compose file #62
Closed
ajliv
ajliv approved these changes Sep 23, 2020
View reviewed changes
Copy link

@ajliv ajliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jritsema jritsema merged commit 2c55339 into develop Sep 23, 2020
@jritsema jritsema deleted the fix/compose-ports branch September 23, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajliv ajliv ajliv approved these changes

@awlawl awlawl Awaiting requested review from awlawl

@mjreed-wbd mjreed-wbd Awaiting requested review from mjreed-wbd

Assignees

@jritsema jritsema

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when deploying a compose file
2 participants
@jritsema @ajliv