updates aws sdk to 1.44.190 for new features #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires go upgrade to 1.17
|
I'll take a look today |
|
@jritsema I did have to regenerate the mocks to get the new interfaces for the aws tools and then the tests pass again. I can do that as a later PR if you want or you can submit those along side this one. Currently in the master branch the unit tests fail on come of the docker compose tests. I think this might be related to the docker compose cli v2 issue. When I switch back to v1, the tests pass. But thats a known issue ATM. |
|
Hey, sorry @awlawl, I forgot to run tests. They should pass now. |
|
Looks good. I'll get this into a pre release this afternoon. Thanks, can't wait to see what New Features means! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for the new ECS Service Connect capability
requires go upgrade to 1.17