Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Po filename customization + multiple po sources #308

Merged
merged 3 commits into from
Nov 25, 2016
Merged

Po filename customization + multiple po sources #308

merged 3 commits into from
Nov 25, 2016

Conversation

Sshnyari
Copy link
Contributor

see #305

@turquoiseowl
Copy link
Owner

Are you able to inclkude a README section to help me and others understand your new feature. Thanks.

@turquoiseowl turquoiseowl merged commit 7b26111 into turquoiseowl:master Nov 25, 2016
@turquoiseowl
Copy link
Owner

Nice work, thanks.

@turquoiseowl
Copy link
Owner

turquoiseowl commented Nov 30, 2016

Just noticed a possible bug introduced by this code.

Before this change, repeated running of PostBuild on a static source file was resulting in the following message in a PO file:

#: Controllers\AccountController.cs:336
msgid "Account creation failed"
msgstr ""

Now I'm getting the message entry as follows:

# Controllers\AccountController.cs:336
#: Controllers\AccountController.cs:336
#, Controllers\AccountController.cs:336
msgid "Account creation failed"
msgstr ""

which I don't think is correct.

@Sshnyari Are you able to look into this please? Thanks.

@turquoiseowl
Copy link
Owner

@Sshnyari To be clear, the first time PostBuild is run, all is correct; it's the second and subsequent times that cause the suspect output.

@Sshnyari
Copy link
Contributor Author

Sshnyari commented Dec 1, 2016

Weird
I also had this issue with a custom post build project, but when I tested it with the solution's post build it seemed to disapear.
I didn't look too much into it.

I have a question about this bit of code (POTranslationRepository.cs:477) :
(k, v) => { v.References = v.References.Append(item.References); var referencesAsComments = item.References.Select(r => r.ToComment()).ToList(); v.ExtractedComments = v.ExtractedComments.Append(referencesAsComments); v.TranslatorComments = v.TranslatorComments.Append(referencesAsComments); v.Flags = v.Flags.Append(referencesAsComments); return v; });

Why are references appended to Flags and translator comments ?
Is this a PO requirement ?

@turquoiseowl
Copy link
Owner

I don't know off-hand.

@Sshnyari
Copy link
Contributor Author

Sshnyari commented Dec 1, 2016

Ok, I'll try to fix it without touching that then

@Sshnyari
Copy link
Contributor Author

Sshnyari commented Dec 1, 2016

it should be OK now in #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants