Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider support for hot-loading #4

Closed
cmelion opened this issue Jun 2, 2015 · 12 comments
Closed

Consider support for hot-loading #4

cmelion opened this issue Jun 2, 2015 · 12 comments
Milestone

Comments

@cmelion
Copy link
Contributor

cmelion commented Jun 2, 2015

https://github.com/gaearon/react-hot-loader

@yamalight
Copy link
Contributor

yeah, I'd seen it and even poked around a bit (quite some time ago).
For some reason it didn't quite worked as expected with the current app structure.
But I'll check again once I have some free time. Also feel free to submit a PR with it :)

@cmelion
Copy link
Contributor Author

cmelion commented Jun 3, 2015

Working on it, new to both react and WebPack so it's not obvious yet,

Sent from my iPhone

On Jun 3, 2015, at 7:47 AM, Tim Ermilov notifications@github.com wrote:

yeah, I'd seen it and even poked around a bit (quite some time ago).
For some reason it didn't quite worked as expected with the current app structure.
But I'll check again once I have some free time. Also feel free to submit a PR with it :)


Reply to this email directly or view it on GitHub.

@yamalight yamalight modified the milestone: v0.3.0 Jun 15, 2015
@yamalight
Copy link
Contributor

Webpack-dev-server currently fails to instantiate websockets because of this issue: socketio/engine.io-client#376
Blocked until socket.io guys close it (update seems to be ready, just not published yet)

@yamalight yamalight added this to the future milestone Jun 15, 2015
@yamalight
Copy link
Contributor

Okay, engine-io issue is resolved, now to wait while webpack-dev-server guys update their deps: webpack/webpack-dev-server#199

@cmelion
Copy link
Contributor Author

cmelion commented Aug 26, 2015

@yamalight is this working yet?

@yamalight
Copy link
Contributor

@cmelion was on vacation, haven't re-checked yet. will probably poke around during the weekend.
but the issue in webpack-dev-server is still open :\

@cmelion
Copy link
Contributor Author

cmelion commented Aug 27, 2015

@yamalight thanks, hope your well rested and had a good vaca.

@yamalight
Copy link
Contributor

@cmelion wasn't bad :)
just tried adding hot reload again - still some errors, but less and they are different now 😄
will try to dig into it a bit more during the week.

@yamalight yamalight removed the blocked label Sep 2, 2015
@yamalight
Copy link
Contributor

@cmelion finally managed to get it working. the biggest issue was with require('bootstrap') and the way webpack requires whole packages when aliases are given.
there are also some small changes needed to be done to pages structure (route needs to be separated from the component). but now it works!
will probably roll out new version with hot reload this week.

@cmelion
Copy link
Contributor Author

cmelion commented Sep 2, 2015

Great! I ran into the Bootstrap issue with the React-Hot-Loader demo as well, but scoping the require to CSS and Fonts only solved it, as you found. The other modification I had to make to support Jenkins build was to use an older version of jsdom compatible with models to support our Jenkins environment.

Sent from my iPhone

On Sep 2, 2015, at 7:42 AM, Tim Ermilov notifications@github.com wrote:

@cmelion finally managed to get it working. the biggest issue was with require('bootstrap') and the way webpack requires whole packages when aliases are given.
there are also some small changes needed to be done to pages structure (route needs to be separated from the component). but now it works!
will probably roll out new version with hot reload this week.


Reply to this email directly or view it on GitHub.

@cmelion
Copy link
Contributor Author

cmelion commented Sep 2, 2015

NodeJS not models, auto-correct strikes again.

Sent from my iPhone

On Sep 2, 2015, at 8:27 AM, Charles cfulnecky@gmail.com wrote:

Great! I ran into the Bootstrap issue with the React-Hot-Loader demo as well, but scoping the require to CSS and Fonts only solved it, as you found. The other modification I had to make to support Jenkins build was to use an older version of jsdom compatible with models to support our Jenkins environment.

Sent from my iPhone

On Sep 2, 2015, at 7:42 AM, Tim Ermilov notifications@github.com wrote:

@cmelion finally managed to get it working. the biggest issue was with require('bootstrap') and the way webpack requires whole packages when aliases are given.
there are also some small changes needed to be done to pages structure (route needs to be separated from the component). but now it works!
will probably roll out new version with hot reload this week.


Reply to this email directly or view it on GitHub.

@yamalight
Copy link
Contributor

shipped in v0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants