-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io.js \ ws \ nan build problem #376
Comments
+1 please Bump version ASAP |
I created pull request: #378 |
The same problem with nodejs 0.12. |
Yes, latest node and io.js are affected. And actually I stepped into this problem after installing socket.io module. |
👍 |
I'm also seeing this problem and traced it back to this point. engine.io-client 1.5.1 depends on ws 0.4.31, which depends on nan 0.3.2, which fails to compile in Windows7x64 with the Visual C++ 2012 compiler. So, please update your dependency on ws to the latest version (0.7.1). Thanks! |
I see #374 fixed this, is there a reason you can't make a release? This has been broken for nearly a month :/ |
Has this been fixed? socket.io depends on this and this fails its installation. |
Maybe yes. But it was forgotten to Inc the version number. So the npm install do not register the new ws@0.7.1 version |
This version does fix the issue but it needs to be on npm. Can you please increment version? |
@rauchg Is anything preventing this to be bumped? |
+1 please bump... |
please update npm to fix this |
calling @rauchg @rase- @TooTallNate please bump the version. |
+1 |
#392 should fix the issue |
As I understand it this package needs to be incremented also |
This gives major issues on many projects (and many tutorials). Pls fix |
+1 |
The funny thing is that engine.io already depends on ws 0.5.0 which does not fail to build. engine.io-client depends on ws 0.4.31 for some reason, though. Hope this is fixed soon as it breaks browser-sync for me,.which depends on socket.io. Mind bumping socket.io deps at the same time? |
+1 waiting for Bumping version |
Is this thread being ignored? 4 months since reported and nothing from maintainers... |
@Karnith i'm guessing they are all mac-users? Its the only logical explanation as this idiotic bug seems to break a lot of projects depending on Socket.IO |
Its extremely frustrating. There are a lot of projects that have come to depend on this one. |
@rauchg are we waiting on anything here? |
Anything Yet? |
Any news on this? |
Preparing the release! |
@rauchg awesome, thanks! |
@yamalight @rauchg thanks! |
We're addressing a bug introduced after a PR we recently merged, and will release after that |
@rauchg any updates on this one? |
got same issue today (win8.1x64/vs2013) |
Also seeing this issue... I rolled back my dependencies as to not be blocked while you address this issue. iojs: v2.3.1 |
Any news here? |
Ya'll got any more of them releases?? |
+1 |
+1 important issue, i still cant compile webpack-dev-server :/ |
@rauchg any updates here? |
+1 also trying to compile webpack-dev-server and failing on Windows |
👍 when they have any attention here, 2month of dead projects |
If webpack-dev-server is failing to compile on windows, it's because a module being used isn't referencing the updated npm package. The ws compile issue was fixed a while ago and pushed to npm a few weeks ago. I verified the whole socket.io series of models work now (unless they just recently pushed to npm within the last few days that broke things again. I'll retest in the morning). |
I just looked. Webpack-dev-server is using "socket.io": "^1.3.3", "socket.io-client": "^1.3.3" which are not the most recent npm version. Webpack-dev-server needs to update modules. |
1.5.2 was published 2 weeks ago on npm so the issue has been fixed. The other modules need to update their version in order to work. But, now the problem is, at least for me with
As far as I'm concerned this issue is closed. |
I think this commit 81374e1 fixes the build for nan part of ws on io.js.
Can you bump the version of the package so it can get the newest version?
The text was updated successfully, but these errors were encountered: