Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.js \ ws \ nan build problem #376

Closed
radum opened this issue Feb 28, 2015 · 44 comments · Fixed by #392
Closed

io.js \ ws \ nan build problem #376

radum opened this issue Feb 28, 2015 · 44 comments · Fixed by #392

Comments

@radum
Copy link

radum commented Feb 28, 2015

I think this commit 81374e1 fixes the build for nan part of ws on io.js.

Can you bump the version of the package so it can get the newest version?

@bagobor
Copy link

bagobor commented Mar 13, 2015

+1 please Bump version ASAP

@bagobor
Copy link

bagobor commented Mar 13, 2015

I created pull request: #378

@nikolaybobrovskiy
Copy link

The same problem with nodejs 0.12.

@bagobor
Copy link

bagobor commented Mar 16, 2015

Yes, latest node and io.js are affected. And actually I stepped into this problem after installing socket.io module.
Which has 'engine.io-client' as dependency.

@frapontillo
Copy link

👍

@jblack10101
Copy link

I'm also seeing this problem and traced it back to this point.

engine.io-client 1.5.1 depends on ws 0.4.31, which depends on nan 0.3.2, which fails to compile in Windows7x64 with the Visual C++ 2012 compiler.

So, please update your dependency on ws to the latest version (0.7.1). Thanks!

@ev-mark
Copy link

ev-mark commented Mar 24, 2015

I see #374 fixed this, is there a reason you can't make a release? This has been broken for nearly a month :/

@hussainb
Copy link

Has this been fixed? socket.io depends on this and this fails its installation.

@deleonio
Copy link

Maybe yes. But it was forgotten to Inc the version number. So the npm install do not register the new ws@0.7.1 version

@nevercast
Copy link

This version does fix the issue but it needs to be on npm. Can you please increment version?
Thank you! 👍

@radum
Copy link
Author

radum commented May 1, 2015

@rauchg Is anything preventing this to be bumped?

@candymanxglobe
Copy link

+1 please bump...

@meodemsao
Copy link

please update npm to fix this

@radum
Copy link
Author

radum commented May 14, 2015

calling @rauchg @rase- @TooTallNate please bump the version.

@thomassuckow
Copy link

+1

@johanneswuerbach
Copy link
Contributor

#392 should fix the issue

@nevercast
Copy link

As I understand it this package needs to be incremented also

@Martinspire
Copy link

This gives major issues on many projects (and many tutorials). Pls fix

@andreialecu
Copy link

+1

@extantpedant
Copy link

The funny thing is that engine.io already depends on ws 0.5.0 which does not fail to build. engine.io-client depends on ws 0.4.31 for some reason, though. Hope this is fixed soon as it breaks browser-sync for me,.which depends on socket.io. Mind bumping socket.io deps at the same time?

@chentsulin
Copy link

+1 waiting for Bumping version

@Karnith
Copy link

Karnith commented Jun 6, 2015

Is this thread being ignored? 4 months since reported and nothing from maintainers...

@Martinspire
Copy link

@Karnith i'm guessing they are all mac-users? Its the only logical explanation as this idiotic bug seems to break a lot of projects depending on Socket.IO

@nevercast
Copy link

Its extremely frustrating. There are a lot of projects that have come to depend on this one.

@defunctzombie
Copy link
Contributor

@rauchg are we waiting on anything here?

@hussainb
Copy link

Anything Yet?

@yamalight
Copy link

Any news on this?

@rauchg
Copy link
Contributor

rauchg commented Jun 15, 2015

Preparing the release!

@yamalight
Copy link

@rauchg awesome, thanks!

@cmelion
Copy link

cmelion commented Jun 15, 2015

@yamalight @rauchg thanks!

@rauchg
Copy link
Contributor

rauchg commented Jun 16, 2015

We're addressing a bug introduced after a PR we recently merged, and will release after that

@jednano
Copy link

jednano commented Jun 24, 2015

@rauchg any updates on this one?

@arturparkhisenko
Copy link

got same issue today (win8.1x64/vs2013)

@SupremeTechnopriest
Copy link

Also seeing this issue... I rolled back my dependencies as to not be blocked while you address this issue.

iojs: v2.3.1
osx: 10.10.3

@yamalight
Copy link

Any news here?

@mikesigs
Copy link

Ya'll got any more of them releases??

@bluedaniel
Copy link

+1

@arturparkhisenko
Copy link

+1 important issue, i still cant compile webpack-dev-server :/

@chentsulin
Copy link

@rauchg any updates here?

@chrispappas
Copy link

+1 also trying to compile webpack-dev-server and failing on Windows

@arturparkhisenko
Copy link

👍 when they have any attention here, 2month of dead projects

@Karnith
Copy link

Karnith commented Jul 22, 2015

If webpack-dev-server is failing to compile on windows, it's because a module being used isn't referencing the updated npm package. The ws compile issue was fixed a while ago and pushed to npm a few weeks ago. I verified the whole socket.io series of models work now (unless they just recently pushed to npm within the last few days that broke things again. I'll retest in the morning).

@Karnith
Copy link

Karnith commented Jul 22, 2015

I just looked. Webpack-dev-server is using "socket.io": "^1.3.3", "socket.io-client": "^1.3.3" which are not the most recent npm version. Webpack-dev-server needs to update modules.

@radum
Copy link
Author

radum commented Jul 22, 2015

1.5.2 was published 2 weeks ago on npm so the issue has been fixed. The other modules need to update their version in order to work.

But, now the problem is, at least for me with browser-sync, that the deep nesting reference to nan fails when msbuild runs, because the path is to long. Moving it to the root of the drive works just fine. But this is not related to this module.

nan should download the binary files for windows and not compile them, this will fix some many issues.

As far as I'm concerned this issue is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.