sdk/rust: Fix hostfs create_file() failing with EEXIST on existing files#315
Open
sdk/rust: Fix hostfs create_file() failing with EEXIST on existing files#315
Conversation
Replace O_EXCL with O_TRUNC in create_file for both Linux and Darwin hostfs backends. The FUSE create op is called by the kernel for open(O_CREAT) on existing files (e.g. cargo overwriting .d dependency files), so create_file needs to truncate rather than fail. Higher-level callers already guard against unwanted overwrites with their own existence checks.
penberg
force-pushed
the
fix-hostfs-create-file
branch
from
d2788f3 to
b080d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace O_EXCL with O_TRUNC in create_file for both Linux and Darwin hostfs backends. The FUSE create op is called by the kernel for open(O_CREAT) on existing files (e.g. cargo overwriting .d dependency files), so create_file needs to truncate rather than fail. Higher-level callers already guard against unwanted overwrites with their own existence checks.