cli: Fix FUSE kernel cache serving stale directory listings #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broady
force-pushed
the
fix/fuse-cache-invalidation
branch
5 times, most recently
from
1c51eb1 to
39a7d7b
Compare
broady
force-pushed
the
fix/fuse-cache-invalidation
branch
from
39a7d7b to
01e992f
Compare
When readdirplus populates the kernel dcache with TTL=MAX, the kernel caches entries indefinitely. After unlink/rmdir/rename the parent directory's cached readdirplus result can still contain stale entries on subsequent ls calls. Fix by sending FUSE_NOTIFY_INVAL_ENTRY after unlink, rmdir, and rename. Notifications are dispatched from a background thread to avoid deadlocking the single-threaded session loop. Add integration test covering unlink, rmdir, rename, create, and mkdir visibility in subsequent readdir.
broady
force-pushed
the
fix/fuse-cache-invalidation
branch
from
01e992f to
7578fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When readdirplus populates the kernel dcache with TTL=MAX, the
kernel caches entries indefinitely. After unlink/rmdir/rename the
parent directory's cached readdirplus result can still contain
stale entries on subsequent ls calls.
Fix by sending FUSE_NOTIFY_INVAL_ENTRY after unlink, rmdir, and
rename. Notifications are dispatched from a background thread to
avoid deadlocking the single-threaded session loop.
Add integration test covering unlink, rmdir, rename, create, and
mkdir visibility in subsequent readdir.