Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute big batches in smaller chunks #130

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Execute big batches in smaller chunks #130

merged 4 commits into from
Jul 23, 2024

Conversation

haaawk
Copy link
Contributor

@haaawk haaawk commented Jul 22, 2024

This fixes two things.

  1. SQLD was just going OOM when the batch was too big
  2. Client memory usage was very high

@haaawk haaawk requested review from penberg and sivukhin July 22, 2024 13:10
sivukhin
sivukhin requested changes Jul 22, 2024
View reviewed changes
sqliteparserutils/utils.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Show resolved Hide resolved
libsql/internal/http/hranaV2/hranaV2.go Outdated Show resolved Hide resolved
haaawk added 3 commits July 23, 2024 09:21
@haaawk
Make sqliteparserutils.CreateStatementIterator public
df5a8d1 
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
@haaawk
Extract hranaV2Conn.closeStream
b05527b 
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
@haaawk
Exctract hranaV2Conn.executeMsg
b0e77e6 
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
@haaawk haaawk force-pushed the streaming_batch branch from aed35f6 to 72cb032 Compare July 23, 2024 11:52
@haaawk haaawk requested a review from sivukhin July 23, 2024 11:53
@haaawk
Execute big batches in chunks
f3e03d5 
Fixes tursodatabase/turso-cli#839
Refs tursodatabase/turso-cli#735

Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
@haaawk haaawk force-pushed the streaming_batch branch from 72cb032 to f3e03d5 Compare July 23, 2024 14:33
@haaawk haaawk requested a review from sivukhin July 23, 2024 14:33
@haaawk haaawk merged commit b944339 into main Jul 23, 2024
2 checks passed
@haaawk haaawk deleted the streaming_batch branch July 23, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivukhin sivukhin sivukhin approved these changes

@penberg penberg Awaiting requested review from penberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haaawk @sivukhin