bottomless: emit restored snapshot for waiters #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a db gets restored from bottomless and doesn't get any writes until shutdown. At this point, the current generation is the same as the restored one but the graceful shutdown process expects to wait for that generation to be uploaded which never happens because there are no writes. This change adds a snapshot generation emit call at restore time to allow graceful shutdown to happen when there are no writes without having to checkpoint and upload a new snapshot.
athoscouto
approved these changes
Mar 22, 2024
shopifyski
pushed a commit
to Shopify/libsql
that referenced
this pull request
Mar 29, 2024
This fixes an issue where a db gets restored from bottomless and doesn't get any writes until shutdown. At this point, the current generation is the same as the restored one but the graceful shutdown process expects to wait for that generation to be uploaded which never happens because there are no writes. This change adds a snapshot generation emit call at restore time to allow graceful shutdown to happen when there are no writes without having to checkpoint and upload a new snapshot.
shopifyski
pushed a commit
to Shopify/libsql
that referenced
this pull request
Mar 29, 2024
This fixes an issue where a db gets restored from bottomless and doesn't get any writes until shutdown. At this point, the current generation is the same as the restored one but the graceful shutdown process expects to wait for that generation to be uploaded which never happens because there are no writes. This change adds a snapshot generation emit call at restore time to allow graceful shutdown to happen when there are no writes without having to checkpoint and upload a new snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a db gets restored from bottomless and doesn't get any writes until shutdown. At this point, the current generation is the same as the restored one but the graceful shutdown process expects to wait for that generation to be uploaded which never happens because there are no writes. This change adds a snapshot generation emit call at restore time to allow graceful shutdown to happen when there are no writes without having to checkpoint and upload a new snapshot.