server: allow explain queries without bind parameters #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SQLite, it is invalid to pass a query with a ? or named parameter without a bind variable, unless you are just trying to explain the command. We always fail those queries, but we shouldn't.
glommer
force-pushed
the
glauber/explain
branch
from
4b96ec1 to
417d6da
Compare
LucioFranco
approved these changes
Mar 25, 2024
LucioFranco
changed the title
shopifyski
pushed a commit
to Shopify/libsql
that referenced
this pull request
Mar 29, 2024
…1256) allow explain queries without bind parameters In SQLite, it is invalid to pass a query with a ? or named parameter without a bind variable, unless you are just trying to explain the command. We always fail those queries, but we shouldn't.
shopifyski
pushed a commit
to Shopify/libsql
that referenced
this pull request
Mar 29, 2024
…1256) allow explain queries without bind parameters In SQLite, it is invalid to pass a query with a ? or named parameter without a bind variable, unless you are just trying to explain the command. We always fail those queries, but we shouldn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SQLite, it is invalid to pass a query with a ? or named parameter without a bind variable, unless you are just trying to explain the command.
We always fail those queries, but we shouldn't.