-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce first iteration of the zig build #1543
base: main
Are you sure you want to change the base?
Conversation
Now it can compile sqlite3 without any extensions and wasm support
this might be reverted later, needs further inspection
Due to the sources being amalgamated, this goes unnoticed. There is no script to generate this file in the current source. Where is this from?
This reverts commit f5ecc9a.
77e6a56 'add libsql_vector tests to veryquick'
This tests seem to fail only because of the lack of the zig binary on the PATH. I don't have experience with this, can someone try guide me on how to fix that? |
Hey @levydsa! There's bunch of changes to |
@penberg The fields of that struct were changed at some point and this definition was incorrect. You can see a warning in the old build of a function pointer type mismatch. Zig makes this a error by default. Using struct initialization prevents this from happening again. I can revert if it I was actually correct. Other changes are to make it easier/possible to build without the amalgamation, but no substantial change other than some additional declarations and includes. Can you point out some other places that could cause problems? |
Hey @levydsa, ideally a build system change like this changes nothing in |
Ok, then. I'll do my best to preserve |
@penberg Done! I can't remove more than that without having to manually concat files to expose declarations. |
No description provided.