Improve headless login #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you run `turso auth login` over ssh, for example, OpenURL() will fail, but in the process it will spam the terminal with the following useless error logs: ``` /usr/bin/xdg-open: line 881: www-browser: command not found /usr/bin/xdg-open: line 881: links2: command not found /usr/bin/xdg-open: line 881: elinks: command not found /usr/bin/xdg-open: line 881: links: command not found /usr/bin/xdg-open: line 881: lynx: command not found /usr/bin/xdg-open: line 881: w3m: command not found xdg-open: no method available for opening 'https://api.turso.io?port=33609&redirect=true' ``` Hide that to improve the developer experience.
If I am in headless mode, there I can't visit an URL on *this* device so improve the help text a bit.
penberg
force-pushed
the
improve-headless-login
branch
from
39559ca to
6025f19
Compare
If we run `turso auth login`, let's fail more gracefully if we fail to open the browser. Without this change, you'll see: ``` $ turso auth login error: Unable to open browser. Visit this URL on this device to log in: https://api.turso.io?port=39935&redirect=true Waiting for authentication... ``` With the change, it's now: ``` $ turso auth login Error: failed to open browser, please use the `--headless` command line option. ```
penberg
force-pushed
the
improve-headless-login
branch
from
6025f19 to
07b45a5
Compare
avinassh
reviewed
Dec 13, 2023
Co-authored-by: Avinash Sajjanshetty <640792+avinassh@users.noreply.github.com>
avinassh
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #736