Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect plan operations to dashboard #907

Merged
merged 4 commits into from
Aug 20, 2024
Merged

redirect plan operations to dashboard #907

merged 4 commits into from
Aug 20, 2024

Conversation

gris
Copy link
Contributor

@gris gris commented Aug 20, 2024

redirect

turso org billing
turso plan select
turso plan upgrade
turso plan overages enable
turso plan overages disable

to https://app.turso.tech/$ORG/settings/billing

also, updates action versions

@gris gris requested a review from athoscouto August 20, 2024 17:24
@gris gris requested a review from notrab August 20, 2024 17:25
Copy link
Contributor

@athoscouto athoscouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say I like the idea of replacing all billing-related commands with opening the web app. This adds a breaking change that is avoidable.

If we don't want plan management on the CLI anymore, I suggest taking the following approach:

  • Hide the current commands, keeping them working as they are today but not advertising them. The exception would be the billing portal, which has a similar behavior today.
  • Create a new and more specific command to manage your turso plan, this would behave the same way as turso org billing, opening up the web app. I suggest turso plan manage.

I don't see a reason to remove plan management logic from the CLI though - which may be totally on me since I'm not following billing-related discussions. If we still want to keep them just changing the behavior of the billing command should be enough.

@gris gris merged commit 567e7be into main Aug 20, 2024
1 of 2 checks passed
@gris gris deleted the redirect-to-dashboard branch August 20, 2024 19:16
avinassh pushed a commit that referenced this pull request Dec 2, 2024
* redirect plan operations to dashboard

* remove unused functions

* fix: update action versions

* fix: hide commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants