Allow appservice user namespace to contain non .*|.+ suffixes #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Sep 1, 2021
| return userId === this.botUserId || (userId.startsWith(this.userPrefix) && userId.endsWith(":" + this.options.homeserverName)); | ||
| return userId === this.botUserId || | ||
| !!this.registration.namespaces?.users.find(({regex}) => | ||
| new RegExp(regex).test(userId) |
There was a problem hiding this comment.
This should probably be cached, but is fine for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not be a breaking change, as we add a new option to the Appservice classenableUserSuffixCheck.Following conversation with @turt2live & @MadLittleMods, we're instead just going to throw in the functions
The rationale behind this change is that existing bridges (particularly those of the matrix-appservice-bridge class) have quite a range of namespace formats. The Gitter bridges uses a very simple number regex, for instance. I'd like to propose that developers should be able to disable the userPrefix check and instead opt out of functions which would require them to have a valid prefix.