Skip to content

Remove deprecated set-output, write to $GITHUB_OUTPUT env file. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

Adnn
Copy link
Contributor

@Adnn Adnn commented Oct 27, 2022

Github action deprecated the used of ::set-output.
I replaced it with the recommanded use of $GITHUB_OUTPUT, from: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@SadieCat
Copy link

Support for set-output is going to be removed soon. Would it be possible for this to be merged and a new release made sooner rather than later? Thanks.

@Adnn
Copy link
Contributor Author

Adnn commented Jan 17, 2023

@offa @patricia-gallardo Anything we can do to help getting this PR merged?

@patricia-gallardo patricia-gallardo merged commit c171f29 into turtlebrowser:main Jan 17, 2023
@patricia-gallardo
Copy link
Contributor

Sorry, GitHub notifications are a mess for me 🙈 next time feel free to ping me on DM on Twitter or mastodon or smoke signals 😅 thank you 🙏

@Adnn
Copy link
Contributor Author

Adnn commented Jan 18, 2023

@patricia-gallardo Thank you for the merge! (I am sorry, I am not really on any other platform you mentioned).

Brief follow-up question: Do you think this deserve a new (minor version) release?

@patricia-gallardo
Copy link
Contributor

Do you think this deserve a new (minor version) release?

I’m at a conference today, but I’ll try to do it tomorrow

@patricia-gallardo
Copy link
Contributor

Forgot to say that I did do a release

@patricia-gallardo
Copy link
Contributor

Closes #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants