Add a hook after connection is established #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a problem using tus-java-client when server is behind the aws load balancer. For things to work correctly, we need to be able to read the
set-cookie
header and send it back on future requests.This could be implemented directly in the client, but I wanted to make as few changes(and as low-impact as possible). So instead I opted to add a hook after connection is opened. In our usage code we subclass
TusClient
and override the newly addedonConnectionOpened
to retrieve the headers andprepareConnection
to inject cookies later on.PS: I think it would be worth making the connection setup and preparation more easily hookable on a more fundamental level so one could use their own custom HTTP stack(without having to resort to the horribly low-level and undiscoverable
URLStreamHandler
).