-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify upload pausing #42
Conversation
Make uploads pausable without closing file input Streams
Add a pause functionality, which doesn't close the InputStream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! We might have hit a road block here, which could complicate matter a bit :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integrated those changes in a slightly different manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few formatting fixes on my own and looks ready now! Thanks!
This PR overloads the TusUploader#finish() method in order to provide a pausable upload, which doesn't close the underlying InputStream.