Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 2 + async upload #35

Merged
merged 11 commits into from
Feb 6, 2020
Merged

drop python 2 + async upload #35

merged 11 commits into from
Feb 6, 2020

Conversation

ifedapoolarewaju
Copy link
Contributor

This PR drops Python 2 support in order to support python3 asyncIO functionalities.
It introduces the AsyncUploader which can be used for async uploads, while the synchronous Uploader also remains available. Proper documentation of these changes will be added in a follow up PR.

Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not expert at Python, so a lot of this is unknown to me, but I didn't find any problem. Since this PR contains breaking changes, we need a new major release, don't we?

@ifedapoolarewaju
Copy link
Contributor Author

I am not expert at Python, so a lot of this is unknown to me, but I didn't find any problem. Since this PR contains breaking changes, we need a new major release, don't we?

Yes, this will be a major release.

@Acconut
Copy link
Member

Acconut commented Feb 4, 2020

Ok, looking good. Feel free to merge when you want.

@ifedapoolarewaju ifedapoolarewaju merged commit ee3a87f into master Feb 6, 2020
@Acconut Acconut deleted the py3 branch February 6, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants