-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop python 2 + async upload #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not expert at Python, so a lot of this is unknown to me, but I didn't find any problem. Since this PR contains breaking changes, we need a new major release, don't we?
Yes, this will be a major release. |
Ok, looking good. Feel free to merge when you want. |
This PR drops Python 2 support in order to support python3 asyncIO functionalities.
It introduces the
AsyncUploader
which can be used for async uploads, while the synchronousUploader
also remains available. Proper documentation of these changes will be added in a follow up PR.