Upgrade AWS SDK, Google Cloud SDK and go-plugin #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the go group with 6 updates: | Package | From | To | | --- | --- | --- | | [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.34.0` | `1.35.1` | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.22.0` | `1.23.4` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.20.0` | `1.25.10` | | [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) | `1.41.0` | `1.47.1` | | [github.com/hashicorp/go-plugin](https://github.com/hashicorp/go-plugin) | `1.5.2` | `1.6.0` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.150.0` | `0.152.0` | Updates `cloud.google.com/go/storage` from 1.34.0 to 1.35.1 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@spanner/v1.34.0...storage/v1.35.1) Updates `github.com/aws/aws-sdk-go-v2` from 1.22.0 to 1.23.4 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.22.0...v1.23.4) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.20.0 to 1.25.10 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.20.0...config/v1.25.10) Updates `github.com/aws/aws-sdk-go-v2/service/s3` from 1.41.0 to 1.47.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.41.0...service/s3/v1.47.1) Updates `github.com/hashicorp/go-plugin` from 1.5.2 to 1.6.0 - [Release notes](https://github.com/hashicorp/go-plugin/releases) - [Changelog](https://github.com/hashicorp/go-plugin/blob/main/CHANGELOG.md) - [Commits](hashicorp/go-plugin@v1.5.2...v1.6.0) Updates `google.golang.org/api` from 0.150.0 to 0.152.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.150.0...v0.152.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/storage dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/service/s3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/hashicorp/go-plugin dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
The build is breaking because of some breaking changes in an AWS SDK release. See #1033 (comment) |
|
On 2023-11-17, a new version of the S3 package from the AWS SDK for Go V2 was released (see https://github.com/aws/aws-sdk-go-v2/releases/tag/release-2023-11-17 and https://github.com/aws/aws-sdk-go-v2/blob/release-2023-11-17/service/s3/CHANGELOG.md#v1430-2023-11-17). Even though the new version number The problem is that this breaking change also affects tusd's users now. If tusd's s3store is used as a package and the user installed a more recent version of the AWS SDK, they will run into compilation error. For example, this happened to a tusd user in #1033. This also happened to other users of the AWS SDK: aws/aws-sdk-go-v2#2162 (comment) What should we do now?
No option is great, but I prefer the first for now. Most people will run into issues sooner or later with the AWS SDK. If we have a release of tusd which works with the latest AWS SDK, we can tell people to just upgrade both dependencies to the most recent version and it should work. |
Acconut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the go group with 6 updates:
1.34.01.35.11.22.01.23.41.20.01.25.101.41.01.47.11.5.21.6.00.150.00.152.0Updates
cloud.google.com/go/storagefrom 1.34.0 to 1.35.1Release notes
Sourced from cloud.google.com/go/storage's releases.
Commits
e3a209dchore(main): release storage 1.35.1 (#8997)8e63c70feat(edgenetwork): new client(s) (#8996)ba23673chore(redis/cluster): Configure clients for google-cloud-redis-cluster (#8980)57491aefeat(bigquery): add DataGovernanceType to routines (#8990)a0b64f8test(bigtable): Adding isolation to app profile (#8982)5d26f0dchore(main): release storage 1.35.0 (#8991)67fe88echore(edgenetwork): add config to generate apiv1 (#8995)99842f0chore(storage): update apiary dependency (#8993)880795echore(owlbot): fix merchant inv API owlbot config (#8992)244d135feat(bigtable): Add support for reverse scans (#8755)Updates
github.com/aws/aws-sdk-go-v2from 1.22.0 to 1.23.4Commits
f3ea5b8Release 2023-11-30bb44374Regenerated Clients1fd796cUpdate SDK's smithy-go dependency to v1.18.15e061f0Update endpoints modele6de9aeUpdate API modela88ff68Release 2023-11-29023df35Regenerated Clients41f99acUpdate SDK's smithy-go dependency to v1.18.072478fbUpdate API model4c4b852feat: add Options() getter to service clients (#2398)Updates
github.com/aws/aws-sdk-go-v2/configfrom 1.20.0 to 1.25.10Commits
f3ea5b8Release 2023-11-30bb44374Regenerated Clients1fd796cUpdate SDK's smithy-go dependency to v1.18.15e061f0Update endpoints modele6de9aeUpdate API modela88ff68Release 2023-11-29023df35Regenerated Clients41f99acUpdate SDK's smithy-go dependency to v1.18.072478fbUpdate API model4c4b852feat: add Options() getter to service clients (#2398)Updates
github.com/aws/aws-sdk-go-v2/service/s3from 1.41.0 to 1.47.1Commits
f3ea5b8Release 2023-11-30bb44374Regenerated Clients1fd796cUpdate SDK's smithy-go dependency to v1.18.15e061f0Update endpoints modele6de9aeUpdate API modela88ff68Release 2023-11-29023df35Regenerated Clients41f99acUpdate SDK's smithy-go dependency to v1.18.072478fbUpdate API model4c4b852feat: add Options() getter to service clients (#2398)Updates
github.com/hashicorp/go-pluginfrom 1.5.2 to 1.6.0Release notes
Sourced from github.com/hashicorp/go-plugin's releases.
Changelog
Sourced from github.com/hashicorp/go-plugin's changelog.
Commits
586d14fChangelog++ for v1.6.0 (#293)7c313e4Configurable buffer size for reading plugin log lines (#265)d16cec3Support muxing gRPC broker connections over a single net.Conn (#288)017b758fix: move client logic to a function that always return (#262)c69982f[COMPLIANCE] Add Copyright and License Headers (#287)337cd57Use buf for proto generation (#286)5492ff9Bump golang.org/x/net from 0.7.0 to 0.17.0 (#285)Updates
google.golang.org/apifrom 0.150.0 to 0.152.0Release notes
Sourced from google.golang.org/api's releases.
Changelog
Sourced from google.golang.org/api's changelog.
Commits
c18c15echore(main): release 0.152.0 (#2267)82f1381feat(all): auto-regenerate discovery clients (#2271)296fb55chore(all): update all (#2275)b1c45c2chore(all): update all (#2260)4ffc629feat(all): auto-regenerate discovery clients (#2270)3138958feat(all): auto-regenerate discovery clients (#2269)980c045feat(all): auto-regenerate discovery clients (#2268)22872aafeat(all): auto-regenerate discovery clients (#2266)df9c71cchore(main): release 0.151.0 (#2254)786dca6feat(all): auto-regenerate discovery clients (#2265)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions