Chore #223 #333 #450 #692
Closed
Chore #223 #333 #450 #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
possibly fix for tus#488 - bumped alpine runtime in dockerfile - get rid of [unmaintained](bmizerany/pat#17) routing library bmizerany/pat - fixed CORS request test (status must be just 404, not 405, consequences of bmizerany/pat)
…s3store_custom_path # Conflicts: # pkg/handler/config.go # pkg/handler/handler.go
|
Thank you very much for your work on this PR! However, I would ask you to avoid combined PRs like this where multiple independent changes are made in a single PR. This makes it hard to review, track changes and messes with the commit history. So please split this PR into multiple :) |
|
Looks like with closed previous PR, that makes no sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR contains further changes after #685:
docs/fix #223 - added startup message about disabled downloads
chore/fix #333:
sec/fix #450 - allow accepting credentials (for example, Cookie, so forwarding in hooks will work as described in docs)