feat: Add flag to control CORS Origin header #942
Conversation
|
@Acconut anything missing to merged this? THX a lot |
|
Thank you for taking on this PR! One thing that was missing from the original PR is that there was no check on the server to see if the origin from the request actually matched the allowed origin as configured using the command line flag. According to #504 (comment), this should be the correct behavior of a server. Could you implement this here as well? If so, I think we could move towards merging this. |
|
I'll take care of this. ETA: gimme a day or two ;-) |
|
Great! Thank you very much already! |
This comment was marked as outdated.
This comment was marked as outdated.
|
@Acconut mind approving the workflow? Would like to know if all test pass ..... THX |
|
@Acconut 👍 or 👎 😀 - THX |
|
Looks like we are having conflicts again .... rebasing .... 🤷 |
|
@Acconut please approve ci - thx |
|
👋 |
|
I don't see any option to allow the CI to run for you as a first-time contributor, even though it should be there as explained in https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks. This might be a bug with GitHub. Could you try creating a new PR and seeing if that helps? |
|
@Acconut see above - THX |
|
That works. I was able to approve the CI run for you in #987. Let's continue in there :) |
rebased version of #504
should also fulfill now the requested change to only apply the CORS header if the origin header is set on request.