fix(color-picker): can't input 0 as unit's value, closes #2680

tusen-ai · Mar 26, 2022 · b4a0fe2 · b4a0fe2
1 parent 214cf5e
commit b4a0fe2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.en-US.md b/CHANGELOG.en-US.md
@@ -10,6 +10,7 @@
 - Fix `n-popconfirm` doesn't has `setShow` & `syncPosition` methods.
 - Fix `n-popselect` doesn't has `setShow` & `syncPosition` methods.
 - Fix `n-menu` theme's peers missing `Dropdown`.
+- Fix `n-color-picker` can't input 0 as unit's value, closes [#2680](https://github.com/TuSimple/naive-ui/issues/2680)
 
 ### Feats
 

diff --git a/CHANGELOG.zh-CN.md b/CHANGELOG.zh-CN.md
@@ -10,6 +10,7 @@
 - 修复 `n-popconfirm` 缺少 `setShow` 和 `syncPosition` 方法
 - 修复 `n-popselect` 缺少 `setShow` 和 `syncPosition` 方法
 - 修复 `n-menu` 主题 peers 缺少 `Dropdown`
+- 修复 `n-color-picker` 不能输入 0 作为单位的值，关闭 [#2680](https://github.com/TuSimple/naive-ui/issues/2680)
 
 ### Feats
 

diff --git a/src/color-picker/src/ColorInputUnit.tsx b/src/color-picker/src/ColorInputUnit.tsx
@@ -98,7 +98,7 @@ export default defineComponent({
           break
         case 'H':
           unit = normalizeHueUnit(value)
-          if (!unit) {
+          if (unit === false) {
             inputValueRef.value = getInputString()
           } else {
             props.onUpdateValue(unit)
@@ -108,15 +108,15 @@ export default defineComponent({
         case 'L':
         case 'V':
           unit = normalizeSlvUnit(value)
-          if (!unit) {
+          if (unit === false) {
             inputValueRef.value = getInputString()
           } else {
             props.onUpdateValue(unit)
           }
           break
         case 'A':
           unit = normalizeAlphaUnit(value)
-          if (!unit) {
+          if (unit === false) {
             inputValueRef.value = getInputString()
           } else {
             props.onUpdateValue(unit)
@@ -126,7 +126,7 @@ export default defineComponent({
         case 'G':
         case 'B':
           unit = normalizeRgbUnit(value)
-          if (!unit) {
+          if (unit === false) {
             inputValueRef.value = getInputString()
           } else {
             props.onUpdateValue(unit)