Skip to content

Commit

Permalink
fix(upload): warning about extraneous non-props attributes were passe…
Browse files Browse the repository at this point in the history
…d but not be automatically inherited, closes #4447
  • Loading branch information
jizai1125 committed Apr 18, 2023
1 parent 81cdbec commit e87101e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.en-US.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- Fix `n-dynamic-input` doesn't return correct `index` in `on-create` callback.
- Fix `trTR` i18n, closes [#4231](https://github.com/tusen-ai/naive-ui/issues/4231).
- Fix `n-input`'s show password icon is offset when use both `password` and `disabled`, closes [#4364](https://github.com/tusen-ai/naive-ui/issues/4364).
- Fix `n-upload` warning cause by extraneous non-props attributes were passed to vue component `TransitionGroup` but could not be automatically inherited, closes [#4447](https://github.com/tusen-ai/naive-ui/issues/4447).

### Feats

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- 修复 `n-dynamic-input` 在点击添加按钮后 `on-create` 返回的 `index` 不正确
- 修复 `trTR` 国际化,关闭 [#4231](https://github.com/tusen-ai/naive-ui/issues/4231)
- 修复 `n-input` 同时使用 `password``disabled` 时,显示密码图标偏移的问题,关闭 [#4364](https://github.com/tusen-ai/naive-ui/issues/4364)
- 修复 `n-upload` 内部使用 vue `TransitionGroup` 组件时, 传递了未声明的 prop 且未被自动继承导致警告, 关闭[#4447](https://github.com/tusen-ai/naive-ui/issues/4447)

### Feats

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,20 @@ export default defineComponent({
}
return () => {
const type = props.group ? TransitionGroup : Transition
const differentProps = props.group ? undefined : { mode: props.mode }
return h(
type as any,
{
name: props.width
? 'fade-in-width-expand-transition'
: 'fade-in-height-expand-transition',
mode: props.mode,
appear: props.appear,
onEnter: handleEnter,
onAfterEnter: handleAfterEnter,
onBeforeLeave: handleBeforeLeave,
onLeave: handleLeave,
onAfterLeave: handleAfterLeave
onAfterLeave: handleAfterLeave,
...differentProps
},
slots
)
Expand Down

0 comments on commit e87101e

Please sign in to comment.