Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

加载Spin组件 圆圈动画有毛刺感 #3556

Closed
aboutZZ opened this issue Aug 20, 2022 · 6 comments · Fixed by #5072
Closed

加载Spin组件 圆圈动画有毛刺感 #3556

aboutZZ opened this issue Aug 20, 2022 · 6 comments · Fixed by #5072

Comments

@aboutZZ
Copy link

aboutZZ commented Aug 20, 2022

TuSimple/naive-ui version (版本)

2.32.2

Vue version (Vue 版本)

3.2.37

Browser and its version (浏览器及其版本)

Chrome 104.0.5112.81

System and its version (系统及其版本)

Win 10

Node version (Node 版本)

Reappearance link (重现链接)

https://www.naiveui.com/zh-CN/os-theme/components/spin

Reappearance steps (重现步骤)

使用加载 Spin组件

Expected results (期望的结果)

——

Actual results (实际的结果)

Spin的圆圈感觉不平滑,有很多凸起的像素,给人造成毛刺感

Remarks (补充说明)

loading gif

仔细看也能发现 时不时有个灰色小像素块在圆圈轨迹上出现

@github-actions github-actions bot added the untriaged need to sort label Aug 20, 2022
@Sepush
Copy link
Collaborator

Sepush commented Aug 20, 2022

这是一个已知问题 在1080p的 windows 系统上应该是必现的

@Sepush Sepush added bug Something isn't working and removed untriaged need to sort labels Aug 20, 2022
@07akioni 07akioni added platform-specific-bug and removed bug Something isn't working labels Aug 20, 2022
@eagleoflqj
Copy link
Contributor

iOS也能看见那个灰色块

@Sepush
Copy link
Collaborator

Sepush commented Aug 21, 2022

这个问题是上次为了修 #2506 在 n-base-loading 实现里用了三个 svg 在旋转动画的时候有错位和抖动 然后导致看起来会有毛刺感 暂时我还不知道怎么修🧐

@0xjeso
Copy link

0xjeso commented Oct 25, 2022

2.33.5目前仍然还有这个问题,这个有点影响观感呀,各位大佬什么时候考虑修一下,感谢🙏

@re-ovo
Copy link

re-ovo commented Jan 28, 2023

win11, 2k屏,也有这个问题

@suica
Copy link
Contributor

suica commented Jul 17, 2023

Strange fur is due to stroke-dasharray value, which cuts the whole circle into several pieces.
And the blinking "gray pixels" is due to that the two rotating circle are not exactly match in frequency.
One can observe those issue easily with a very very heavy stroke.
spin1
The original implementation (before the fix of #2506) is pretty good and has none of those issues, so i modified the original implementation to make the animation work with the call of blocking methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants