Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base-loading): revert to the old code & make animation work with blocking method & fix fur in animation #5072

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

suica
Copy link
Contributor

@suica suica commented Jul 17, 2023

closes #3556

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
naive-ui ❌ Failed (Inspect) Dec 20, 2023 7:15pm

@suica suica changed the title fix(loading): revert to the old code & make animation work with blocking method and & fix fur in animation fix(loading): revert to the old code & make animation work with blocking method & fix fur in animation Jul 17, 2023
@suica suica changed the title fix(loading): revert to the old code & make animation work with blocking method & fix fur in animation fix(base-loading): revert to the old code & make animation work with blocking method & fix fur in animation Jul 17, 2023
@suica suica temporarily deployed to test July 17, 2023 09:49 — with GitHub Actions Inactive
@suica suica temporarily deployed to test July 17, 2023 09:49 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (437ce23) 62.38% compared to head (d2a60ce) 62.38%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5072   +/-   ##
=======================================
  Coverage   62.38%   62.38%           
=======================================
  Files        1074     1074           
  Lines       22587    22588    +1     
  Branches     5929     5929           
=======================================
+ Hits        14091    14092    +1     
  Misses       6953     6953           
  Partials     1543     1543           
Impacted Files Coverage Δ
src/_internal/loading/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/_internal/loading/src/Loading.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sepush
Copy link
Collaborator

Sepush commented Jul 17, 2023

may add a demo for js blocking case like this one https://codesandbox.io/s/currying-hooks-ef7g87?file=/src/App.vue

@suica suica temporarily deployed to test July 17, 2023 13:47 — with GitHub Actions Inactive
@suica suica temporarily deployed to test July 17, 2023 13:47 — with GitHub Actions Inactive
@Sepush
Copy link
Collaborator

Sepush commented Jul 17, 2023

not blocking but animation get slow,Is this acceptable?cc @07akioni

20230717-215120

@suica
Copy link
Contributor Author

suica commented Jul 17, 2023

This is because I wrapped the svg with a rotating container, which has a longer period than the spinner itsself.
It turns out we cannot use svg animation and css animation together and expect them to have the same phase. Svg animation will be blocked by JS, but simple css animation will not.
So we need to replace all svg animation with css animation. Is there any way to construct css animation in tsx file?

@07akioni
Copy link
Collaborator

This is because I wrapped the svg with a rotating container, which has a longer period than the spinner itsself. It turns out we cannot use svg animation and css animation together and expect them to have the same phase. Svg animation will be blocked by JS, but simple css animation will not. So we need to replace all svg animation with css animation. Is there any way to construct css animation in tsx file?

Using css-render

@07akioni
Copy link
Collaborator

not blocking but animation get slow,Is this acceptable?cc @07akioni

20230717-215120 20230717-215120

It used to be this.

@07akioni 07akioni merged commit 9699e9b into tusen-ai:main Dec 20, 2023
3 checks passed
liuzw2579 pushed a commit to liuzw2579/ithinkdt-ui that referenced this pull request Dec 21, 2023
…blocking method & fix fur in animation (tusen-ai#5072)

* fix(loading): revert to old version & fix fur in animation

* chore(loading): update changelog

* fix(loading): change class name for failed tests

* doc(spin): add debug demos

---------

Co-authored-by: 07akioni <07akioni2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

加载Spin组件 圆圈动画有毛刺感
4 participants