-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(base-loading): revert to the old code & make animation work with blocking method & fix fur in animation #5072
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
=======================================
Coverage 62.38% 62.38%
=======================================
Files 1074 1074
Lines 22587 22588 +1
Branches 5929 5929
=======================================
+ Hits 14091 14092 +1
Misses 6953 6953
Partials 1543 1543
☔ View full report in Codecov by Sentry. |
may add a demo for js blocking case like this one https://codesandbox.io/s/currying-hooks-ef7g87?file=/src/App.vue |
not blocking but animation get slow,Is this acceptable?cc @07akioni |
This is because I wrapped the svg with a rotating container, which has a longer period than the spinner itsself. |
Using |
It used to be this. |
…blocking method & fix fur in animation (tusen-ai#5072) * fix(loading): revert to old version & fix fur in animation * chore(loading): update changelog * fix(loading): change class name for failed tests * doc(spin): add debug demos --------- Co-authored-by: 07akioni <07akioni2@gmail.com>
closes #3556