Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form-item): add prefix slot #2051

Closed
wants to merge 2 commits into from
Closed

feat(form-item): add prefix slot #2051

wants to merge 2 commits into from

Conversation

Sepush
Copy link
Collaborator

@Sepush Sepush commented Dec 27, 2021

Signed-off-by: Sepush sepush@outlook.com

close #1142

Signed-off-by: Sepush <sepush@outlook.com>
@vercel
Copy link

vercel bot commented Dec 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/G49MGijtbDTykWbVFpg6p2VvKCwy
✅ Preview: https://naive-ui-git-fork-sepush-form-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #2051 (83fe127) into main (d598565) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 83fe127 differs from pull request most recent head 9b48a74. Consider uploading reports for the commit 9b48a74 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2051      +/-   ##
==========================================
- Coverage   64.73%   64.72%   -0.02%     
==========================================
  Files         899      898       -1     
  Lines       17668    17616      -52     
  Branches     4201     4175      -26     
==========================================
- Hits        11438    11402      -36     
+ Misses       5444     5427      -17     
- Partials      786      787       +1     
Impacted Files Coverage Δ
src/form/src/FormItem.tsx 38.73% <ø> (-1.00%) ⬇️
src/form/src/Feedbacks.tsx 28.57% <33.33%> (-4.77%) ⬇️
src/tabs/src/Tab.tsx 67.39% <0.00%> (-9.21%) ⬇️
src/avatar/src/AvatarGroup.tsx 76.66% <0.00%> (-6.67%) ⬇️
src/data-table/src/DataTable.tsx 76.38% <0.00%> (-6.22%) ⬇️
src/form/src/Form.tsx 41.46% <0.00%> (-5.21%) ⬇️
src/result/src/Result.tsx 96.15% <0.00%> (-3.85%) ⬇️
src/tabs/src/Tabs.tsx 62.31% <0.00%> (-3.06%) ⬇️
src/drawer/src/Drawer.tsx 66.07% <0.00%> (-2.35%) ⬇️
src/drawer/src/DrawerBodyWrapper.tsx 82.60% <0.00%> (-1.40%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ecb8e...9b48a74. Read the comment docs.

@Talljack
Copy link
Contributor

感觉这个slot name不是符合

@Sepush
Copy link
Collaborator Author

Sepush commented Dec 28, 2021

感觉这个slot name不是符合

取名大困难

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add form item slot for feedback text
2 participants