-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(carousel): adds css theme variables #2350
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tusimple/naive-ui/Bm9c5n8m8gbaarsCdQi96aNBSJWA |
Codecov Report
@@ Coverage Diff @@
## main #2350 +/- ##
==========================================
- Coverage 63.62% 63.45% -0.17%
==========================================
Files 946 946
Lines 19137 19240 +103
Branches 4825 4871 +46
==========================================
+ Hits 12175 12208 +33
- Misses 5851 5883 +32
- Partials 1111 1149 +38
Continue to review full report at Codecov.
|
感觉这种用 props 之类的实现更合适一点,这变量太长了,应该抽象抽象 |
这样写感觉可以更加灵活的去控制高度和宽度的比例,给两个属性来控制会不会太冗余了一点,但是名字确实是有点长了。 |
7477557
to
57e0e5b
Compare
This pull request introduces 1 alert when merging 57e0e5b into c1c22cc - view on LGTM.com new alerts:
|
57e0e5b
to
4bc7019
Compare
4bc7019
to
6d3313c
Compare
@07akioni 现在这种处理呢 |
周末我看一下哈 |
经过我一段时间的研究,最终还是决定使用 |
#2340