-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(transfer): add source-filterable
and target-filterable
props
#3428
feat(transfer): add source-filterable
and target-filterable
props
#3428
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #3428 +/- ##
==========================================
- Coverage 63.03% 63.00% -0.03%
==========================================
Files 1056 1056
Lines 21877 21898 +21
Branches 5695 5698 +3
==========================================
+ Hits 13790 13797 +7
- Misses 6601 6614 +13
- Partials 1486 1487 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
baaab46
to
ea5ec8b
Compare
Codecov Report
@@ Coverage Diff @@
## main #3428 +/- ##
==========================================
- Coverage 63.03% 62.95% -0.08%
==========================================
Files 1056 1056
Lines 21877 21940 +63
Branches 5695 5721 +26
==========================================
+ Hits 13790 13813 +23
- Misses 6601 6634 +33
- Partials 1486 1493 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
} | ||
|
||
function handleCheckedAll (): void { | ||
doUpdateValue([...valueSetForSelectAllRef.value]) | ||
function handleUnCheckedAll (): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncheck 是一个单词
return props.options.filter((opt) => filter(srcPatternRef.value, opt)) | ||
return targetOptionsRef.value.filter((opt) => | ||
filter(tgtPatternRef.value, opt, 'target') | ||
) | ||
}) | ||
|
||
const mergedValueSetRef = computed<Set<string | number>>(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个语义已经被改掉了,不应该叫这个名字
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没看出来这么改有啥好处
你原先那么写有问题,逻辑都散了,数据的逻辑不能散开 |
closes #3407