Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Image and Avatar): add onError and objectFit props #485

Merged
merged 4 commits into from
Jul 14, 2021

Conversation

Talljack
Copy link
Contributor

@Talljack Talljack commented Jul 13, 2021

close #394

@Talljack Talljack requested review from 07akioni and Volankey July 13, 2021 02:12
@vercel
Copy link

vercel bot commented Jul 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/4DKLU68QyvxTdLP87iNitQM2AqjP
✅ Preview: https://naive-ui-git-fork-talljack-naive-ui-394-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #485 (60c32ce) into main (8201231) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   37.06%   37.06%           
=======================================
  Files         507      507           
  Lines       12180    12180           
  Branches     3353     3353           
=======================================
  Hits         4515     4515           
  Misses       6803     6803           
  Partials      862      862           
Impacted Files Coverage Δ
src/avatar/src/Avatar.tsx 93.75% <ø> (ø)
src/image/src/Image.tsx 76.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8201231...60c32ce. Read the comment docs.

Copy link
Collaborator

@Volankey Volankey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文档里面相关的props和event还没加上吧

src/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
src/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
src/image/src/Image.tsx Outdated Show resolved Hide resolved
@07akioni
Copy link
Collaborator

话说还没发布的文档更新,不要发到 docs

CHANGELOG.en-US.md Outdated Show resolved Hide resolved
CHANGELOG.zh-CN.md Outdated Show resolved Hide resolved
src/avatar/src/Avatar.tsx Outdated Show resolved Hide resolved
src/avatar/src/styles/index.cssr.ts Outdated Show resolved Hide resolved
src/image/tests/Image.spec.tsx Outdated Show resolved Hide resolved
src/image/src/styles/index.cssr.ts Outdated Show resolved Hide resolved
src/image/src/Image.tsx Outdated Show resolved Hide resolved
src/image/src/Image.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avatar and image component enhancements
3 participants