Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): readonly prop should only be Boolean #6397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jizai1125
Copy link
Contributor

@jizai1125 jizai1125 commented Sep 27, 2024

readonly: {
   type: [String, Boolean]
}
<!-- parsed as an empty string -> readonly="" -->
<n-input readonly  />

The readonly prop used to accept both String and Boolean, but was parsed as readonly="", which made the clear icon show up.

image

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
naive-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:45am

@jizai1125 jizai1125 changed the title fix(input): readonly prop should only be Boolean due to Vue casting rule fix(input): readonly prop should only be Boolean Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant