Fix(input): placeholder bug #918

Volankey · 2021-08-19T10:58:53Z

Closes #914

vercel · 2021-08-19T10:58:57Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/CkxvD4s7bMsYUhQGQNTiHp1TCBQa
✅ Preview: https://naive-ui-git-fork-volankey-914-tusimple.vercel.app

codecov · 2021-08-19T11:03:07Z

Codecov Report

Merging #918 (609694e) into main (f682501) will decrease coverage by 0.42%.
The diff coverage is 100.00%.

❗ Current head 609694e differs from pull request most recent head 3289ec4. Consider uploading reports for the commit 3289ec4 to get more accurate results

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   45.06%   44.64%   -0.43%     
==========================================
  Files         509      509              
  Lines       12463    12460       -3     
  Branches     3503     3501       -2     
==========================================
- Hits         5617     5563      -54     
- Misses       5847     5896      +49     
- Partials      999     1001       +2

Impacted Files	Coverage Δ
src/input/src/Input.tsx	`45.09% <100.00%> (+0.18%)`	⬆️
src/slider/src/Slider.tsx	`16.97% <0.00%> (-9.82%)`	⬇️
src/modal/src/BodyWrapper.tsx	`30.15% <0.00%> (-7.94%)`	⬇️
src/_internal/selection/src/Selection.tsx	`31.38% <0.00%> (-3.20%)`	⬇️
src/tree-select/src/TreeSelect.tsx	`22.80% <0.00%> (-1.76%)`	⬇️
src/modal/src/Modal.tsx	`29.16% <0.00%> (-1.39%)`	⬇️
src/timeline/src/Timeline.tsx	`100.00% <0.00%> (ø)`
src/data-table/src/styles/index.cssr.ts	`100.00% <0.00%> (ø)`
src/image/src/ImagePreview.tsx	`25.20% <0.00%> (+0.40%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f682501...3289ec4. Read the comment docs.

07akioni · 2021-08-19T16:48:34Z

src/input/src/utils.ts

+export function isEmptyValue (value: any): boolean {
+  return ['', undefined, null].includes(value)
+}


这个逻辑看起来不是很通用，别放在这里

07akioni · 2021-08-19T16:49:25Z

CHANGELOG.zh-CN.md

@@ -5,6 +5,7 @@
 ### Fixes

 - 修复 `n-notification` 导出的 `NotificationReactive` 类型不可变，关闭 [#876](https://github.com/TuSimple/naive-ui/issues/876)
+- 修复 `n-input` `placeholder` bug，关闭 [#914](https://github.com/TuSimple/naive-ui/issues/914)


把问题写全了，语焉不详不好

* fix(input): placeholder bug * update changelog * update doc * feat(input): optimization Co-authored-by: Jiwen Bai <56228105@qq.com> Co-authored-by: 07akioni <07akioni2@gmail.com>

vercel bot deployed to Preview August 19, 2021 10:58 View deployment

Volankey changed the title ~~914~~ Fix(input): placeholder bug #914 Aug 19, 2021

Volankey changed the title ~~Fix(input): placeholder bug #914~~ Fix(input): placeholder bug Aug 19, 2021

XieZongChen approved these changes Aug 19, 2021

View reviewed changes

07akioni reviewed Aug 19, 2021

View reviewed changes

RobotVol added 4 commits August 20, 2021 13:41

fix(input): placeholder bug

b392c61

update changelog

3757f6e

update doc

4010d33

feat(input): optimization

609694e

Volankey force-pushed the 914 branch from b104b9e to 609694e Compare August 20, 2021 05:45

vercel bot deployed to Preview August 20, 2021 05:45 View deployment

Merge branch 'main' into 914

3289ec4

vercel bot deployed to Preview August 25, 2021 05:14 View deployment

07akioni merged commit dd92889 into tusen-ai:main Aug 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix(input): placeholder bug #918

Fix(input): placeholder bug #918

Volankey commented Aug 19, 2021 •

edited

Loading

vercel bot commented Aug 19, 2021 •

edited

Loading

codecov bot commented Aug 19, 2021 •

edited

Loading

07akioni Aug 19, 2021

07akioni Aug 19, 2021

Fix(input): placeholder bug #918

Fix(input): placeholder bug #918

Conversation

Volankey commented Aug 19, 2021 • edited Loading

vercel bot commented Aug 19, 2021 • edited Loading

codecov bot commented Aug 19, 2021 • edited Loading

Codecov Report

07akioni Aug 19, 2021

Choose a reason for hiding this comment

07akioni Aug 19, 2021

Choose a reason for hiding this comment

Volankey commented Aug 19, 2021 •

edited

Loading

vercel bot commented Aug 19, 2021 •

edited

Loading

codecov bot commented Aug 19, 2021 •

edited

Loading