0.1.1 Added source class for GCP BigQuery #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrutunjay-kinagi
added
enhancement
tusharchou
changed the title
tusharchou
reviewed
Oct 28, 2024
...-data-platform/real_world_use_cases/near_data_lake/config/sample_queries/near_transaction.py
Outdated
Show resolved
Hide resolved
|
This looks great @mrutunjay-kinagi !!!! |
redpheonixx
reviewed
Oct 28, 2024
|
@tusharchou , @redpheonixx : Time for you guys to review again ! |
tusharchou
reviewed
Oct 29, 2024
| @@ -11,7 +11,7 @@ class Pipeline(Flow): | |||
|
|
|||
| def __init__(self, config: Config, *args, **kwargs): | |||
| self.config = config | |||
| self.source = Source(**config.metadata['source']) | |||
| self.target = Target(**config.metadata['target']) | |||
| # self.source = Source(**config.metadata['source']) | |||
There was a problem hiding this comment.
@mrutunjay-kinagi what went wrong here?
tusharchou
approved these changes
Oct 29, 2024
redpheonixx
reviewed
Oct 29, 2024
| from pathlib import Path | ||
| import json | ||
| from local_data_platform import Credentials | ||
| from local_data_platform import logger |
There was a problem hiding this comment.
this should be
from local_data_platform.logger import log
redpheonixx
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name: Added source class for GCP BigQuery
About: Implemented BigQuery integration with local-data-platform
Description : This implementation enables local-data-platform to pull data from BigQuery , store it as CSV and Upload CSV data to Iceberg.
Is your pull request related to a issue? Please tag. #19