-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conversations #2556
Fix conversations #2556
Conversation
draft because some details still aren't perfect |
While this is a hundred times better than before, there are still 2 glitches:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a not so confident with all the paging APIs but maybe it's worth leaving a comment on how/why order
works? I don't understand it fully, does server not reorder them all the time?
Yes it does reorder it all the time but I also reload it all the time. After a pull to refresh there is only the current page in the cache. |
# Conflicts: # app/schemas/com.keylesspalace.tusky.db.AppDatabase/38.json # app/src/main/java/com/keylesspalace/tusky/db/AppDatabase.java
This fixes several problems with conversations (the code is basically just taken over from the newer timeline code)
kind of a prerequisite to #2552
I'd like to merge this at the same time as #2549 because the migrations overlap