feat: Change name of Preferences > Filters > Tabs and move them to Account Preferences(#3536) #4115
Conversation
In the previous code, when you open preferences, there is a section headed "Filters" with a section called "Tabs" This is confusing. Therefore, make the following changes - Change the section title from "Filters" to "Per-timeline preferences." - Change the current "Tabs" section to "Home timeline" since it is only for home timelines Fixes tuskyapp#3536
Remove the following sharedPreferences as they are unnecessary. - TAB_FILTER_HOME_REPLIES - TAB_FILTER_HOME_BOOSTS - TAB_SHOW_HOME_SELF_BOOSTS Also, update sharedPreferences accordingly. Fixes tuskyapp#3536
| @@ -45,7 +45,7 @@ enum class AppTheme(val value: String) { | |||
| * | |||
| * - Adding a new preference that does not change the interpretation of an existing preference | |||
| */ | |||
| const val SCHEMA_VERSION = 2023082301 | |||
| const val SCHEMA_VERSION = 2023112001 | |||
There was a problem hiding this comment.
I don't know if this way of updating SharedPreferences is correct, so this commit is a bit suspect
So, please point out if I am wrong!
|
Are you possibly forgetting about this PR? |
|
It is true that it would be better to rename it as you said! |
|
@connyduck Of course, setting the new one to "Local filters" is no problem at all. |
|
I'm fine with both |
|
Fixed as shown in the image above. |
connyduck
changed the title
|
Can you explain to me the meaning of the second commit, "update: Remove unnecessary sharedPreferences"? Were these fields already or are they made irrelevant by this patch changing them to per-account values? Thanks. Also, I have put up a PR #4128 , if that is accepted this PR will need to change its version number to acommodate it. |
Yes, exactly.
In other words, this PR needs to update its DB version to 56 instead of 55, is that right? |
|
Thanks for explaining.
If the PR is accepted. (But there were no objections either here or on Matrix over a while so I guess it is getting accepted?) |
|
Updated PR with 55->56 change as discussed. I tested this builds but did not test running it or performing an upgrade. Sanao, this will probably cause your local copy to crash until you do an uninstall/reinstall cycle (because the code knows how to update 54->56 but not from your 55 to 56) |
Posted this as issue #3999 before. The reasoning is personal experiments and forks may add database fields and must bump the database number to do so, but this causes massive merge difficulties when Tusky then inevitably itself bumps the number. To alleviate this, Tusky official should use only even database numbers, so odd versions are available for third party scribbling. There was little discussion positive or negative in #3999 (one proposal we switch to a date-based number system, which would work but also could be unnecessarily complicated). With PR #4115 we now have to make a decision because that's the first post-proposal PR to bump the database number odd. So, since I see no outright objections, I'd like to implement this. @connyduck suggested the best way to implement the proposal would be to add a comment to the version number's home in AppDatabase.java. Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
Overview
In the previous code, when you open preferences, there is a section headed "Filters" with a section called "Tabs"
This is confusing.
Changes
Screenshots
Note
Related link
Fixes #3536