Better screen transitions #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
force-pushed
the
better-screen-transitions
branch
from
80ec54d to
9193121
Compare
|
Noticed that "home timeline" preferences transition are slightly broken because fragment has no background color |
charlag
force-pushed
the
better-screen-transitions
branch
from
32c4bf6 to
524eec8
Compare
|
should I merge it? |
|
I was just waiting for Google Play to publish a nightly, because every new upload resets the position in the queue and most of the recent changes haven't been published. They have now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly took Android 13 transitions and removed the sliding for the "deeper"/background one because "extend" animations are not available until Android 13.
Here are the original ones: https://cs.android.com/android/platform/superproject/+/android-13.0.0_r8:frameworks/base/core/res/res/anim/;bpv=1
Initially I've made separate versions fro Android 13+ that are close to the original but I think it's not worth it to keep both.
tusky_transitions.mp4